-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ViscoElasticContacts
#248
base: main
Are you sure you want to change the base?
Conversation
ViscoElasticContactModel
ViscoElasticContacts
ed97707
to
986854e
Compare
Hi @diegoferigo, another early comment since I'm testing this contact model: in Lines 378 to 387 in 986854e
From jaxsim/src/jaxsim/api/contact.py Lines 235 to 236 in 986854e
|
986854e
to
8a7e3ae
Compare
Thanks @xela-95 for the feedback. The dictionary returned by the visco-elastic contact model is somewhat different then the one returned by the soft contact model. The latter returns Regardless, I'm still unsure how to integrate the new visco-elastic contacts with the default |
aee7fc2
to
d534a25
Compare
d534a25
to
7556b6b
Compare
7556b6b
to
2bd727b
Compare
This PR implements a revised and ―possibly― improved contact model originally proposed in the following manuscript:
Although the theory is not yet public, my implementation proposes the following improvements:
viscoelastic_contacts_ergocub.mp4
Open points left to future work:
jax.scipy.linalg.expm
. However, beyond implementing the logic, which is doable, we should also figure out how to expose AD. It's not clear to me what could be the performance degradation of relying to pure AD w.r.t. the usage of the custom adjoints as done internally in JAX.📚 Documentation preview 📚: https://jaxsim--248.org.readthedocs.build//248/